Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command- syntax capturing for --success #325

Merged
merged 2 commits into from May 22, 2022
Merged

Fix command- syntax capturing for --success #325

merged 2 commits into from May 22, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented May 20, 2022

Fixes #324

@paescuj paescuj requested a review from gustavohenke May 20, 2022 07:51
@paescuj paescuj added the bug label May 20, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.903% when pulling 4bfb91a on paescuj:fix-success-condition-command-pattern into 6f1e11d on open-cli-tools:master.

gustavohenke
gustavohenke approved these changes May 22, 2022
View reviewed changes
src/completion-listener.ts Outdated Show resolved Hide resolved
@paescuj @gustavohenke
Relaxing condition for non-match of command-syntax
6a9b035 
Co-authored-by: Gustavo Henke <guhenke@gmail.com>
@paescuj paescuj merged commit ecbc325 into open-cli-tools:main May 22, 2022
@paescuj paescuj deleted the fix-success-condition-command-pattern branch May 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

command-${string}-formatted --success condition fails with dashes
3 participants
@paescuj @coveralls @gustavohenke