Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies & declare recommended extensions for VSCode #320

Merged
merged 4 commits into from May 17, 2022
Merged

Update dependencies & declare recommended extensions for VSCode #320

merged 4 commits into from May 17, 2022

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented May 16, 2022

With those updates there are no more npm WARN deprecated notifications during installation.

Minor updates

date-fns                            2.16.1  →    2.28.0
yargs                               17.3.1  →    17.5.1
@types/jest                         27.0.3  →    27.5.1
@types/lodash                     4.14.178  →  4.14.182
@types/node                         17.0.0  →   17.0.33
@types/yargs                        17.0.8  →   17.0.10
@typescript-eslint/eslint-plugin     5.8.1  →    5.23.0
@typescript-eslint/parser            5.8.1  →    5.23.0
rxjs                                 6.6.3  →     6.6.7
ts-node                             10.4.0  →    10.7.0
typescript                           4.5.4  →     4.6.4

Major updates

eslint                              7.17.0  →    8.15.0
jest                                26.6.3  →    27.5.1
jest-create-mock-instance            1.1.0  →     2.0.0
ts-jest                             26.5.6  →    27.1.4

jest has only been updated to version 27, as an update to 28 would need to be looked at more closely (compatibility with jest-create-mock-instance, etc.).

The coveralls package seems to be unmaintained and has been replaced with coveralls-next.

The following major updates were intentionally omitted for now, as these need to be looked at more closely:

chalk                                4.1.2  →     5.0.1
rxjs                                 6.6.7  →     7.5.5
supports-color                       8.1.1  →     9.2.2

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.903% when pulling cf81547 on paescuj:update-deps into 55b8cae on open-cli-tools:master.

@paescuj paescuj requested a review from gustavohenke May 16, 2022 10:42
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

The non-dev major upgrades must be done with care not to introduce breaking changes (e.g. dropping support for some Node.js version)

@paescuj paescuj merged commit 6f1e11d into open-cli-tools:master May 17, 2022
@paescuj paescuj deleted the update-deps branch May 17, 2022 08:48
@paescuj
Copy link
Collaborator Author

paescuj commented May 17, 2022

Thanks.

The non-dev major upgrades must be done with care not to introduce breaking changes (e.g. dropping support for some Node.js version)

I totally agree with you! (I even took a quick look at the changelogs for the minor updates included in this pull request)

@paescuj paescuj added enhancement dependencies Pull requests that update a dependency file labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants