Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix for wildcard naming #212

Merged

Conversation

transitive-bullshit
Copy link
Contributor

Fixes #211
Fixes #148

See #211 for more info and a repro case.

@coveralls
Copy link

coveralls commented Jan 6, 2020

Pull Request Test Coverage Report for Build 372

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.919%

Totals Coverage Status
Change from base Build 370: -0.3%
Covered Lines: 480
Relevant Lines: 480

💛 - Coveralls

@transitive-bullshit
Copy link
Contributor Author

@gustavohenke the coveralls issue seems to be a false positive.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thank you!
I'll loosen the Coveralls integration 😃

@gustavohenke
Copy link
Member

gustavohenke commented Jan 11, 2020

Before merging, I thought of checking how v3 would behave.
It seems that

  1. Empty wildcard match means no command name
  2. Passing --name arg would prefix the wildcard match
$ ../src/main.js npm:foo-*-baz
[bar]
[bar] > @ foo-bar-baz /some/dir
[bar] > echo foo bar baz
[bar]
[1]
[1] > @ foo--baz /some/dir
[1] > echo foo--baz
[1]
[bar] foo bar baz
[1] foo--baz
[bar] npm run foo-bar-baz exited with code 0
[1] npm run foo--baz exited with code 0

$ ../src/main.js -n test npm:foo-*-baz
[test]
[test] > @ foo--baz /some/dir
[test] > echo foo--baz
[test]
[testbar]
[testbar] > @ foo-bar-baz /some/dir
[testbar] > echo foo bar baz
[testbar]
[testbar] foo bar baz
[test] foo--baz
[test] npm run foo--baz exited with code 0
[testbar] npm run foo-bar-baz exited with code 0

WDYT?

@poteirard
Copy link

Any progress on this?

@brokenmass
Copy link

@gustavohenke : can this be merged, please ?

@sunknudsen
Copy link

@gustavohenke Thanks so much for concurrently. What is holding back this PR?

Looking forward to the behavior illustrated in the docs which will save precious space in the terminal.

concurrently "npm:watch-*"

# Equivalent to:
concurrently -n js,css,node "npm run watch-js" "npm run watch-css" "npm run watch-node"

@LucasForster
Copy link

1. Empty wildcard match means no command name

2. Passing `--name` arg would prefix the wildcard match

WDYT?

Seems like the expected behavior. Would love to see this merged, I was wondering why my console output wouldn't match what is described in the docs.

And thanks for the package, of course!

@gustavohenke
Copy link
Member

Builds all failed because of Coverage, but will merge anyway since everything else is passing and I've applied the suggested changes above!

@gustavohenke gustavohenke merged commit dd54b9f into open-cli-tools:master Dec 19, 2021
@gustavohenke
Copy link
Member

Published as v6.5.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard naming is verbose and doesn't match docs Run template commands
7 participants