fix: use wildcard values as names #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| command: `npm run ${script}${args}`, | ||
| name: script | ||
| name: (commandInfo.names || '') + script.match(wildcardRegex)[1] |
There was a problem hiding this comment.
The right property is name
| { name: 'w:foo', command: 'npm run watch-foo' }, | ||
| { name: 'w:bar', command: 'npm run watch-bar' }, | ||
| ]); | ||
| }) |
| } | ||
| }); | ||
|
|
||
| expect(parser.parse({ names: 'w:', command: 'npm run watch-*' })).toEqual([ |
There was a problem hiding this comment.
will have to fix the property here too to name (see above)
|
My bad, should be all fixed now :) |
There was a problem hiding this comment.
Thanks for the PR, it looks good.
Now I'm unsure about it, though. #148 doesn't state what the problem actually is.
What you are doing here is reverting the prefixing strategy back to what v3 had -- I'm not sure which style is the preferred one by the users, and might even be a breaking change.
| @@ -28,7 +28,7 @@ module.exports = class ExpandNpmWildcard { | |||
| .filter(script => wildcardRegex.test(script)) | |||
| .map(script => Object.assign({}, commandInfo, { | |||
There was a problem hiding this comment.
I rolled this line back to what it is on master, as some other information will exist on commandInfo
Closed
|
Closing as it's fixed by #211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #148