Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take an array as options #22

Open
oorestisime opened this issue Apr 14, 2019 · 7 comments
Open

Take an array as options #22

oorestisime opened this issue Apr 14, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@oorestisime
Copy link
Owner

Right now if user needs more than one profile or hashtag or.. they need to add the plugin multiple times in the configuration.
The plugin could take an object or an array of objects to improve the options declaration. Handling both cases would help avoid a breaking change.

@oorestisime oorestisime added the enhancement New feature or request label Apr 14, 2019
@BarrBozzO
Copy link

@oorestisime is this functionality implemented?

@oorestisime
Copy link
Owner Author

nope. PR welcome if you want

@BarrBozzO
Copy link

Yeap, we can try to implement this.

@BarrBozzO
Copy link

BarrBozzO commented Jun 9, 2020

@oorestisime So should we allow to provide options next way?

{
    resolve: 'gatsby-source-instagram',
    options: [ 
        { type: 'hashtag', hashtag: 'snowing' },
        { username: 'XXXXXX' }
    ] 
}

or smth like that

{
    resolve: 'gatsby-source-instagram',
    options: {
       origins: [ 
            { type: 'hashtag', hashtag: 'snowing' },
            { username: 'XXXXXX' }
        ] 
    }
}

@oorestisime
Copy link
Owner Author

hm i think first way is more concise and better?
also just for information I won't be able to merge this until I finalize release of #24 because we are probably dropping hashtag and profile support since they no longer work. Not sure if this affects what you are currently building but just keep that in mind :)

@BarrBozzO
Copy link

yeah, let's wait for #24 . Not cool that you need to stop hashtag and profile support(

@oorestisime
Copy link
Owner Author

I haven't researched this but maybe the graph api supports getting hashtag and maybe it could be supported through that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants