Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrolib/seo -- HTML5 Validation Errors #435

Open
ShoGinn opened this issue Apr 30, 2024 · 2 comments
Open

@astrolib/seo -- HTML5 Validation Errors #435

ShoGinn opened this issue Apr 30, 2024 · 2 comments

Comments

@ShoGinn
Copy link
Contributor

ShoGinn commented Apr 30, 2024

I opened an issue on onwidget/astrolib#15 (comment)

The issue is that meta tags and link tags in SEO are generated using the void style, which is against HTML standards.

More details are in the dependencies, but it plays a factor for astrowind.

Details

Example from 404.html

  1:1926  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:1970  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2036  error  Expected omitted end tag <link> instead of self-closing element <link/>  void-style
  1:2083  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2182  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2253  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2297  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2403  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2444  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style
  1:2507  error  Expected omitted end tag <meta> instead of self-closing element <meta/>  void-style

@prototypa
Copy link
Contributor

Hi @ShoGinn

Thank you for this. Very valid. I was quickly reviewing the PR in astrolib and it looks very interesting. As soon as possible I do a deep review and approve the PR.

@ShoGinn
Copy link
Contributor Author

ShoGinn commented May 1, 2024

@prototypa Thanks for indulging my contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants