You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi,
There is a very subtle breaking change from 1.22.1 to version 1.23.0
The prototype of Eventually changed to some thing that is causing compile errors on old code.
The previous declaration was
These are explicitly different. The version in 1.22.1 requires at least one argument and the version in 1.23.0 does not require any argument.
Why it is not backardly compatible?
The flattening of arrays into veradic arguments is broken ... see below.
On go 1.19.3, 1.19.2 and 1.18.5 we have this issue which you can replicate using this sample test code
functest1(args...string) {}
functest2(namestring, args...string) {}
functestFail() {
colours:= []string{"orange", "green"}
// this does not compile: Invalid use of '...', the corresponding parameter is non-variadictest1("Fred", colours...)
// this compilestest2("Fred", colours...)
}
This change needs to be reverted or it needs to be 2.0.0 to keep the semantic versioning.
The text was updated successfully, but these errors were encountered:
hi,
There is a very subtle breaking change from 1.22.1 to version 1.23.0
The prototype of Eventually changed to some thing that is causing compile errors on old code.
The previous declaration was
The declation in 1.23.0 is
These are explicitly different. The version in 1.22.1 requires at least one argument and the version in 1.23.0 does not require any argument.
Why it is not backardly compatible?
The flattening of arrays into veradic arguments is broken ... see below.
On go 1.19.3, 1.19.2 and 1.18.5 we have this issue which you can replicate using this sample test code
This change needs to be reverted or it needs to be 2.0.0 to keep the semantic versioning.
The text was updated successfully, but these errors were encountered: