Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reading from a closed gbytes.Buffer #575

Merged
merged 1 commit into from Aug 27, 2022

Conversation

davidhsingyuchen
Copy link
Contributor

@davidhsingyuchen davidhsingyuchen commented Aug 25, 2022

Summary

PR addresses #573. I thought about updating the test case to ensure that a closed buffer can be read, but I later thought that the test case might not exist in the first place if we enabled reading from a closed buffer when the Read was added (i.e., 8 years ago), so I decided to completely remove the test case.

Test

$ ginkgo -r -p
Running Suite: Gbytes Suite - D:\main\dev\davidhsingyuchen\gomega\gbytes
========================================================================
Random Seed: 1661405848

Will run 39 of 39 specs
Running in parallel across 11 processes
+++++++++++++++++++++++++++++++++++++++

Ran 39 of 39 Specs in 0.245 seconds
SUCCESS! -- 39 Passed | 0 Failed | 0 Pending | 0 Skipped


Ginkgo ran 1 suite in 3.3358401s
Test Suite Passed

@davidhsingyuchen
Copy link
Contributor Author

Rebased against master to get the fix included in cb46517.

@onsi
Copy link
Owner

onsi commented Aug 27, 2022

Thanks @davidhsingyuchen !

@onsi onsi merged commit 061fd26 into onsi:master Aug 27, 2022
@davidhsingyuchen davidhsingyuchen deleted the read-closed-buffer branch August 27, 2022 18:59
@davidhsingyuchen
Copy link
Contributor Author

Hi @onsi, could you help cut a release? Thanks!

@onsi
Copy link
Owner

onsi commented Aug 31, 2022

Done! This is out on v1.20.2 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants