Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vet optional description args in assertions, fixing #560 #566

Merged
merged 1 commit into from Jul 25, 2022

Conversation

thediveo
Copy link
Collaborator

@thediveo thediveo commented Jul 25, 2022

  • panics when it detects a Gomega Matcher in the first position of optional description args.
  • accepts Gomega Matchers as part of an optional description when in other positions as args to the formatted first description arg.
  • comes with unit tests.

@onsi
Copy link
Owner

onsi commented Jul 25, 2022

looks great!!

@onsi onsi merged commit 8e37808 into onsi:master Jul 25, 2022
@thediveo thediveo deleted the issue-560-vet-extra-matchers branch July 26, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants