HaveExistingField matcher #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thediveo
commented
May 7, 2022
thediveo
commented
- implements issue RFC: a "forgiving" HaveField matcher #548 with new HaveExistingField matcher
- modifies existing extractField helper from HaveField for reuse with HaveExistingField
- adds new unit tests for HaveExistingField matcher
- updates documentation
|
whoops! sorry for the delay. I took a look and this makes sense. The notion of a severe error in the implementation also makes sense. An alternative could be to return an explicit FieldNotFoundError and key off of that in the HaveExistingField matcher but it's nbd. we can merge as is imo |
|
Your suggestion about changing from severe error to field-not-found absolutely makes sense and semantically much more so than the notion of severe error. I will refactor the PR, highly appreciated suggestion! |
- implements new HaveExistingField matcher - modifies existing extractField helper from HaveField for reuse with HaveExistingField - adds new unit tests for HaveExistingField matcher - updates documentation
thediveo
force-pushed
the
existing-field-matcher
branch
from
ed51c4b
to
a9e85e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.