Fix for Go 1.18 #532
Merged
Fix for Go 1.18 #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are not triggering for some reason. |
|
odd - not sure why the tests aren't running. thanks so much for digging into this @BooleanCat and sorry I haven't been able to be more responsive. I'll merge this in and run things locally against 1.18 and cut a new release once I get a few more gomega PRs pulled in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes gomega for Go 1.18 and drops support for Go 1.16 (end of lifed).
Change summary:
GO11MODULE=offfor functions that compile test binariesFixes #531