Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HaveValue matcher #485

Merged
merged 4 commits into from Dec 7, 2021
Merged

Add HaveValue matcher #485

merged 4 commits into from Dec 7, 2021

Conversation

thediveo
Copy link
Collaborator

  • adds HaveValue matcher (as discussed in [RFC] new Value matcher? #484) that optionally dereferences pointers and interfaces into values, even repeatedly, as needed.
  • adds tests for HaveValue matcher.

@onsi
Copy link
Owner

onsi commented Nov 29, 2021

hey @thediveo sorry for the delay (🦃-day and all). This looks good but I'm gonna make a couple comments on the commit.

matchers/have_value.go Outdated Show resolved Hide resolved
matchers/have_value.go Outdated Show resolved Hide resolved
@thediveo
Copy link
Collaborator Author

thediveo commented Dec 3, 2021

After finally being able to dynamically create arbitrary deep stargazing actual values using reflection, what do you prefer? Augmenting the PR with new commits or replacing the commits (if latter, how so)?

matchers/have_value.go Outdated Show resolved Hide resolved
@onsi
Copy link
Owner

onsi commented Dec 7, 2021

lgtm - thanks!

I have a couple of new things I want to add to Gomega this/next week - once that's done I'll cut a new release.

@onsi onsi merged commit bdc087c into onsi:master Dec 7, 2021
@thediveo thediveo deleted the thediveo-havevalue branch December 7, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants