Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get github.com/onsi/gomega/... produces error #468

Closed
janakiramanmesh7 opened this issue Aug 24, 2021 · 4 comments
Closed

go get github.com/onsi/gomega/... produces error #468

janakiramanmesh7 opened this issue Aug 24, 2021 · 4 comments

Comments

@janakiramanmesh7
Copy link

src/github.com/onsi/gomega/gmeasure/cache.go:69:18: undefined: os.ReadDir

@blgm
Copy link
Collaborator

blgm commented Aug 24, 2021

Hi @janakiramanmesh7

The os.ReadDir() function was added in Go 1.16. Go 1.16 is the minimum supported version of Go.

We realise that for various reasons people may need to stay on older versions of Go. In this case, it's worth pinning to a specific version of Gomega that supported that version. This allows for the Gomega project to move forward, and you can update at a later stage. For instance, you could use the release v1.16.0 as this does not have a usage of os.ReadDir().

@stmcginnis
Copy link

As of December, we're now on go 1.17. Even go 1.16 was dropped as of #532. Looks like this can be closed?

@thediveo
Copy link
Collaborator

Maybe we can document how to pin? Using a replace statement in go.mod?

@onsi
Copy link
Owner

onsi commented Mar 31, 2022

imo I think it's ok to close this out. I imagine google will bring folks to this thread and they can pin to an older version. I don't think they need to do a replace (?) - rather go get github.com/onsi/gomega@v1.16.0 should be enough?

@onsi onsi closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants