feat: HaveHTTPStatus multiple expected values #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the HaveHTTPStatus() matcher failed, the whole HTTP response object was printed out, and any message was rendered in bytes rather than as a string. This introduces a formatter for HTTP responses, so that the key data is presented in a helpful format.
blgm
force-pushed
the
have-http-status-multiple-value
branch
from
a2583e0
to
6481fcb
Compare
Sometimes more than one HTTP status is acceptable. For example a server may (correctly) return HTTP 204 for an empty response, or it might return HTTP 200 for an empty response - and we might want to accept either. We can now write: ```go Expect(resp).To(HaveHTTPStatus(http.StatusOK, http.StatusNoContent)) ``` And it will match either. This is simpler than using Or() or SatisfyAny().
blgm
force-pushed
the
have-http-status-multiple-value
branch
from
6481fcb
to
c573b36
Compare
blgm
added a commit
that referenced
this pull request
Aug 17, 2021
onsi
pushed a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this builds on #461, so that should be merged first.
Sometimes more than one HTTP status is acceptable. For example a server
may (correctly) return HTTP 204 for an empty response, or it might
return HTTP 200 for an empty response - and we might want to accept
either.
We can now write:
And it will match either. This is simpler than using Or() or
SatisfyAny().