Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gexec.Build should create a binary with an expected name #446

Merged
merged 1 commit into from May 31, 2021

Conversation

aminjam
Copy link
Contributor

@aminjam aminjam commented May 25, 2021

Changes introduced in #410 is breaking backward compatibility for building binaries with an expected name.

Changes introduced in onsi#410 is breaking backward compatibility
for building binaries with an expected name.
@blgm
Copy link
Collaborator

blgm commented May 31, 2021

This makes sense to me. I have seen it break backwards compatibility, although it's not strictly a breaking change since there was never a guarantee of the binary name. If there was a clear benefit from having a pseudo-random binary name, then it might be worth it, but I can't really see any advantage at all.

@blgm blgm merged commit 7356360 into onsi:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants