Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow environment variables to override the default Eventually and Consistently timeouts #434

Closed
onsi opened this issue Apr 5, 2021 · 0 comments · Fixed by #443
Closed

Allow environment variables to override the default Eventually and Consistently timeouts #434

onsi opened this issue Apr 5, 2021 · 0 comments · Fixed by #443
Labels
enhancement

Comments

@onsi
Copy link
Owner

onsi commented Apr 5, 2021

@vito raised this issue on Ginkgo a century ago:
onsi/ginkgo#528

But it's probably best solved in Gomega with an environment variable that can override the default timeouts.
tlwr added a commit to tlwr/gomega that referenced this issue May 6, 2021
@tlwr
Set consistently and eventually defaults on init
0a6db1e 
Closes onsi#434

Signed-off-by: toby lorne <toby@toby.codes>
@tlwr tlwr mentioned this issue May 6, 2021
Merged
tlwr added a commit to tlwr/gomega that referenced this issue May 7, 2021
@tlwr
Set consistently and eventually defaults on init
5e6f879 
Using environment variables

Closes onsi#434

Signed-off-by: toby lorne <toby@toby.codes>
@onsi onsi closed this as completed in #443 May 21, 2021
onsi pushed a commit that referenced this issue May 21, 2021
@tlwr
Set consistently and eventually defaults on init (#443)
12eb778 
Using environment variables

Closes #434

Signed-off-by: toby lorne <toby@toby.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set consistently and eventually defaults on init tlwr/gomega
2 participants
@onsi @blgm