Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gexec could build test packages #410

Comments

@holyhope
Copy link
Contributor

holyhope commented Feb 4, 2021

Hello folks,

Context

I would like to run conformance tests from opencontainers in the suite test of harbor-operator.

Following the conformance documentation, the recommended way is to compile the test using go test -c.

Expected behavior

I tried to use the gexec package to compile tests.
I found the BuildXXX functions to compile go packages, but nothing to compile tests.

I suggest to add new functions called BuildTest(packagePath string, args ...string) (compiledPath string, err error)

WDYT?

@onsi
Copy link
Owner

onsi commented Feb 4, 2021

Sounds fine to me - are you up for submitting a PR?

@onsi onsi closed this as completed in 47c613f Feb 25, 2021
This was referenced Mar 8, 2021
aminjam pushed a commit to cloudfoundry/diego-release that referenced this issue May 25, 2021
onsi/gomega#410 changd [the way gexec.Build
works](onsi/gomega@47c613f#diff-f868d960b07c27674436212c91b6468fa357ca1e09a8211d2b8d2c6fab36419aR200-R203)

This is causing an issue when we need to know the name of executable
e.g. sshd instead of sshd-123433
aminjam pushed a commit to aminjam/gomega that referenced this issue May 25, 2021
Changes introduced in onsi#410 is breaking backward compatibility
for building binaries with an expected name.
blgm pushed a commit that referenced this issue May 31, 2021
Changes introduced in #410 is breaking backward compatibility
for building binaries with an expected name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment