Implement PanicWith().
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #382 for documentation changes. |
|
Please note that the CI failure was only for Go v1.12, I don't believe it to be related to these changes. |
|
I've updated this PR to produce more description failure messages when a panic does occur, but not with the expected value. |
|
Any idea about the next step for this PR? |
|
@DblK yep yep, I am hopefully going to find time to review it today. Thanks for the bump, I lose track of things so easily these days :) |
williammartin
approved these changes
May 6, 2020
|
Looks great to me. Don't mind the 1.12 failure, something orthogonal. Thanks! |
|
Happy to finally contribute! Would I be out of line asking when this might make it into a tag? 😄 |
|
OUT OF ORDER! We'll have to check out the 1.12 failure before doing a release but otherwise asap. |
|
Excellent, thank you! |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
I finally got around to making an attempt at
PanicWith()as discussed in the aforementioned issue which I opened quite some time ago.I've stuck with the name
PanicWith()as we didn't manage to come up with anything better in the issue when it was last discussed.