Remove unnecessary conversions #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sample_01 is already a byte slice. Those conversions don't make any difference.
|
I agree with you, but it seems like we should just remove this test. The assertion is already made in other tests. |
|
@muesli, thank you for spotting this problem. Because we haven't heard from you in a while I'm going to merge this PR so that you get GitHub contributor credit, and then immediately delete the test as suggested by @williammartin above to remove duplication. Thank you for you helping to make Gomega better! |
blgm
added a commit
that referenced
this pull request
Aug 19, 2019
- `sample_01` is already a byte slice, so casting it makes no differrence - there is already an identity test for `sample_01` - see #357 for context
|
@blgm Thank you, that's very kind! Also I'm sorry, I didn't realize you were waiting for my action or feedback. What @williammartin mentioned sounded absolutely reasonable, I was just expecting other to chime in or a clear signal how to progress with this PR. Thanks for resolving it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_01 is already a byte slice. Those conversions don't make any difference.