spec tree in docs

[axilis-marko]

I was going through the docs and came up on something in the Mental model .
This is the code layout used as an example in the section:

var _ = Describe("Books", func() {
  var book *books.Book

  BeforeEach(func() {
    //Closure A
    book = &books.Book{
      Title: "Les Miserables",
      Author: "Victor Hugo",
      Pages: 2783,
    }
    Expect(book.IsValid()).To(BeTrue())
  })

  Describe("Extracting names", func() {
    When("author has both names", func() {
      It("extracts the last name", func() {        
        //Closure B
        Expect(book.AuthorLastName()).To(Equal("Hugo"))
      })

      It("extracts the first name", func() {
        //Closure C
        Expect(book.AuthorFirstName()).To(Equal("Victor"))
      })      
    })

    When("author has one name", func() {
      BeforeEach(func() {
        //Closure D
        book.Author = "Hugo"
      })  

      It("extracts the last name", func() {
        //Closure E
        Expect(book.AuthorLastName()).To(Equal("Hugo"))
      })

      It("returns empty first name", func() {
        //Closure F
        Expect(book.AuthorFirstName()).To(BeZero())
      })
    })

  })
})

And it goes on to say:

"We could represent the spec tree that Ginkgo generates as follows:"

Describe: "Books"
  |_BeforeEach: <Closure-A>
  |_Describe: "Extracting names"
  |_When: "author has both names"
    |_It: "extracts the last name", <Closure-B>
    |_It: "extracts the first name", <Closure-C>
  |_When: "author has one name"
    |_BeforeEach: <Closure-D>
    |_It: "extracts the last name", <Closure-E>
    |_It: "returns empty first name", <Closure-F>

Shouldn’t it be that the When nodes are subnodes of the second Describe? Giving the following spec tree:

Describe: "Books"
  |_BeforeEach: <Closure-A>
  |_Describe: "Extracting names"
    |_When: "author has both names"
      |_It: "extracts the last name", <Closure-B>
      |_It: "extracts the first name", <Closure-C>
    |_When: "author has one name"
      |_BeforeEach: <Closure-D>
      |_It: "extracts the last name", <Closure-E>
      |_It: "returns empty first name", <Closure-F>

[onsi]

Hey @axilis-marko - you are exactly right. thanks for catching that! I've just pushed a fix up now.