Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginkgo v2 CLI breaks when v1 is used #1346

Open
steve-hb opened this issue Jan 26, 2024 · 2 comments
Open

Ginkgo v2 CLI breaks when v1 is used #1346

steve-hb opened this issue Jan 26, 2024 · 2 comments

Comments

@steve-hb
Copy link

When setting up new projects, Goland (IntelliJ IDEA) imports the v1 by default.
This always causes headaches in my team due to the incompatibility of various flags (or passing them to the library used by the project) and therefore wastes times until someone figures out the old version was used and just upgrades every reference to /v2.

Proposal: Reject or at least warn the user when v1 was used in the project.

@onsi
Copy link
Owner

onsi commented Jan 29, 2024

hey @steve-hb - this makes sense to add to the v2 cli. though it's gonna be a bit before I can get to it. are you up for working on a PR if I point you at the right places?

also have you opened an issue over with the IntelliJ folks. I bet this is generic issue with versioned go modules where the ide has no idea which version you want (I wonder if there's a way to tell it "always use v2").

@steve-hb
Copy link
Author

When I find the time, I may be able to do it, but next weeks I'm not available.

I'll create a ticket with IntelliJ folks, didn't think of that tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants