Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GinkgoT: does not skip internal code by default #1330

Open
pohly opened this issue Jan 5, 2024 · 1 comment
Open

GinkgoT: does not skip internal code by default #1330

pohly opened this issue Jan 5, 2024 · 1 comment

Comments

@pohly
Copy link
Contributor

pohly commented Jan 5, 2024

Reproducer:

var _ = ginkgo.Describe("something", func() {
	ginkgo.It("fails", func(ctx context.Context) {
		ginkgo.GinkgoT().Fatal("this failure is intentional")
	})
})

Output:

[FAILED] this failure is intentional
  
  In [It] at: /nvme/gopath/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:889 @ 01/03/24 12:02:50.498

It works when using ginkgo.GinkgoT(1).

Either that should be the default or stack unwinding needs to know that it can skip ginkgo/v2/internal.

@ebabani
Copy link
Contributor

ebabani commented Jan 9, 2024

This should be fixed in #1333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants