Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Finer-Grained Shared Resources and Parallelism #1292

Open
onsi opened this issue Oct 31, 2023 · 8 comments
Open

Proposal: Finer-Grained Shared Resources and Parallelism #1292

onsi opened this issue Oct 31, 2023 · 8 comments
Labels

Comments

@onsi
Copy link
Owner

onsi commented Oct 31, 2023

I'd like to propose some new behavior for Ginkgo and am looking for feedback. The intent here is to solve long-standing problems that keep recurring, particularly for users who build large complex integration suites (e.g. k8s e2e suites).

Please take a look at the proposal up on hackmd.io:

https://hackmd.io/@onsi/By32R9AfT

and either comment on the doc at the link or in the comments below.

@XenoPhex
Copy link

XenoPhex commented Nov 3, 2023

I did a quick read of the proposal and at face everything outlined seems like a great addition! I'll have more time to pick through it over the weekend to really think through the Subsuites side of things. But the new Exclusive functionality is a fantastic improvement - no notes there!

👏🏽

@onsi
Copy link
Owner Author

onsi commented Nov 3, 2023

Thanks for taking a look @XenoPhex !

@pohly
Copy link
Contributor

pohly commented Nov 13, 2023

I went through the proposal. Lot's of useful stuff, thanks for considering this change. I left one comment (just for clarification), the proposal itself looks good to me.

@onsi
Copy link
Owner Author

onsi commented Nov 13, 2023

Thanks @pohly !

@chombium
Copy link

Hi @onsi! The proposal looks very interesting. For me it would mean no more shuffling and ordering test suites, so that the actual tests are run after a test server is build and available for use and faster test runs because I don't have to serialize everything :)
This will also bring more clarity and readability when writing tests.

@onsi
Copy link
Owner Author

onsi commented Nov 16, 2023

thanks @chombium - that’s exactly what i’m hoping this enables :) glad to hear you’re seeing it too :)

@Dannyb48
Copy link
Contributor

Hi @onsi I like this! As a member of team that leverages Ginkgo heavily for integration/system/e2e type tests that rely on the ordered function quite a bit this opens up some new possibilities!

@onsi
Copy link
Owner Author

onsi commented Nov 16, 2023

thanks for taking a look @Dannyb48 ! now i just need to implement it all, lol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants