Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use go-task/slim-sprig Fork instead of masterminds/sprig. #1010

Closed
Dan6erbond opened this issue Jul 25, 2022 · 1 comment
Closed

Why use go-task/slim-sprig Fork instead of masterminds/sprig. #1010

Dan6erbond opened this issue Jul 25, 2022 · 1 comment

Comments

@Dan6erbond
Copy link

Basically the title. This package is one of the few that I am aware of, which us a forked version of Sprig templates by masterminds, instead of the main repo. Was this a mistake running go mod tidy or something similar, or is this intentional?

If so, I have to wonder why we're using a fork that seems to be intended for development purposes only, and not the well-known repo that is used by many well known organizations and projects, and also scores higher on deps.dev:

Open Source Insights

Open Source Insights

If in the future security issues arise, this fork might not receive vital updates whereas I believe the main repo has a much higher chance of staying reliable.

@blgm
Copy link
Collaborator

blgm commented Jul 25, 2022

Here's the original conversation: #775

In summary the idea was that slim-sprig added fewer dependencies, resulting in a potentially lower security risk relating to keeping dependencies up to date. But your point about the more heavily used one potentially getting more updates is valid.

Just because this decision was made in the past, it doesn't mean that it's the correct decision for now.

@onsi onsi closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants