Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Use protobuf's generator to generate pyi stubs #6034

Open
justinchuby opened this issue Mar 25, 2024 · 1 comment · May be fixed by #6096
Open

[Feature request] Use protobuf's generator to generate pyi stubs #6034

justinchuby opened this issue Mar 25, 2024 · 1 comment · May be fixed by #6096
Assignees
@kumar-ish
Labels
better engineering Improve engineering quality of the project contributions welcome enhancement Request for new feature or operator good first issue Good for getting started
Milestone
1.17

Comments

@justinchuby
Copy link
Contributor

justinchuby commented Mar 25, 2024 •
edited

Describe the feature

It looks like protobuf now offers a native way for generating pyi files: https://github.com/protocolbuffers/protobuf/blob/main/python/README.md#implementation-backends. Currently in ONNX we use a custom script. The official tool has the potential to be more correct and robust.
@justinchuby justinchuby added enhancement Request for new feature or operator good first issue Good for getting started contributions welcome labels Mar 25, 2024
@justinchuby justinchuby added this to the 1.17 milestone Mar 25, 2024
@justinchuby justinchuby added the better engineering Improve engineering quality of the project label Mar 25, 2024
@kumar-ish kumar-ish linked a pull request Apr 22, 2024 that will close this issue
Open
@kumar-ish
Copy link

Hi @justinchuby, I've tried to address this in #6096 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar-ish kumar-ish

Labels
better engineering Improve engineering quality of the project contributions welcome enhancement Request for new feature or operator good first issue Good for getting started
Projects
None yet
Milestone
1.17
Development

Successfully merging a pull request may close this issue.

Move to using protogen's .pyi file generator kumar-ish/onnx
2 participants
@justinchuby @kumar-ish