Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX is broken when built with ONNX_USE_LITE_PROTO=OFF (using protobuf-24.4): File already exists in database: onnx/onnx-ml.proto #6094

Open
yurivict opened this issue Apr 20, 2024 · 5 comments
Labels
bug build Issues related to ONNX builds and packages contributions welcome

Comments

@yurivict
Copy link

yurivict commented Apr 20, 2024

Failures are like:

  1. optimizer_test.py failure on litprotobuf ERROR optimizer#38
  2. 'import torch_geometric' fails: File already exists in database: onnx/onnx-ml.proto pyg-team/pytorch_geometric#9220

This appears tot be a long-standing problem, at least since 2021.

I just verified that building with ONNX_USE_LITE_PROTO=ON fixes the problem.

ONNX_USE_LITE_PROTO downloads prototbuf-22.3 sources, which works without a problem.
Without ONNX_USE_LITE_PROTO the package protobuf-24.4 is used, which has this problem.

Is the problem due to protobuf-24.4 incompatibility?

Could you please fix it?

Version: 1.16.0

@yurivict yurivict added the bug label Apr 20, 2024
@yurivict yurivict changed the title ONNX is broken when built with ONNX_USE_LITE_PROTO=OFF: File already exists in database: onnx/onnx-ml.proto ONNX is broken when built with ONNX_USE_LITE_PROTO=OFF (using protobuf-24.4): File already exists in database: onnx/onnx-ml.proto Apr 22, 2024
@justinchuby
Copy link
Contributor

The issue predates protobuf-24.4, so I am not sure?

@justinchuby
Copy link
Contributor

I think it is due to another package linking to onnx at the same time: https://groups.google.com/g/protobuf/c/RZRCnOywdSk/m/HsOaheyFCQAJ

@yurivict
Copy link
Author

PyTorch links to onnx, and then torch_geometric links to PyTorch. What would be the other package?

@justinchuby justinchuby added build Issues related to ONNX builds and packages contributions welcome labels Apr 23, 2024
@justinchuby
Copy link
Contributor

PyTorch builds with ONNX. I wonder why it would fail with torch_geometric? Does setting BUILD_SHARED_LIBS help?

@yurivict
Copy link
Author

BUILD_SHARED_LIBS is in which project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Issues related to ONNX builds and packages contributions welcome
Projects
None yet
Development

No branches or pull requests

2 participants