Find and fix memory leaks

[justinchuby]

Enable ASan and fix memory leaks following #4823

@jcwchen @gramalingam

[justinchuby]

• The MSVC team recently test ONNX project failed to run test on release configuration on windows_x64.  #4287

[zhenhuaw-me]

Hi @justinchuby, if there is instruction about how to enable ASan/LSan in ONNX and run?

We recently see more segfault reports of tools that are built on ONNX package. They usually stuck or crash in protobuf's CopyFrom() function which is invoked by onnx.save(). And the system memory (hundreds of GB) are all taken by the process.

cc @kevinch-nv

[justinchuby]

I don’t think we have an option yet. https://github.com/onnx/onnx/blob/main/CMakeLists.txt is what we will have to edit. @jcwchen is that right?

Contribution/help would be much appreciated!

[justinchuby]

This is a previously failed attempt: #5053

[jcwchen]

I don’t think we have an option yet. https://github.com/onnx/onnx/blob/main/CMakeLists.txt is what we will have to edit. @jcwchen is that right?

I can confirm that currently there is no predefined build option to enable memory check. To enable it, developers need to manually add sanitizer options into DCMAKE_CXX_FLAGS. For example, https://github.com/onnx/onnx/pull/4823/files.