New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX 1.10] Fix for compilation error on older compilers #3683
Conversation
Signed-off-by: Michal Karzynski <michal.karzynski@intel.com>
b0171e1
to
fecd2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's good to make it compatible with older C++. Thanks for catching this.
This seems to have been identified as a bug in C++11 and was later corrected. We can make this change to support older compilers but given gcc 4.8 is pretty old wondering whether we should request users to update gcc . How urgent is this change? Can we discuss this in this week's arch-infra op-sig meeting? |
The change itself makes sense to me, since the fix/benefit comes at no cost/downside. We can decouple the question of whether we need another release from this PR, I think. |
Signed-off-by: Michal Karzynski <michal.karzynski@intel.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Ashwini Khade <askhade@microsoft.com>
Description
ONNX 1.10 fails to compile when using older versions of
gcc
, for example on CentOS, with the following error:Steps to reproduce
Build the following
Dockerfile
to observe the issue:Motivation and Context
This small change fixes the issue.
It may be a reason to make another point-release of ONNX 1.10