Generate shortlive token #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoCo-Japan-pan
force-pushed
the
generate-shortlive-token
branch
2 times, most recently
from
4d51d2b
to
5f028cb
Compare
CoCo-Japan-pan
force-pushed
the
generate-shortlive-token
branch
4 times, most recently
from
7bbca31
to
597b24a
Compare
CoCo-Japan-pan
force-pushed
the
generate-shortlive-token
branch
from
597b24a
to
e069dc6
Compare
|
一時的なアクセストークンをrefresh tokenを用いて取得した場合、それはマスクされないので、これもマスクするようにしました。 |
|
マスクし直すより online-judge-tools/oj#917 をやった方が安全だと思いました。 cc. @koba-e964 |
|
上記の PR とも関係しますが、リフレッシュトークンを使ってトークンを更新するのは online-judge-tools/oj の責務のようです。
が妥当ではないかと思いました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #436
環境変数
DROPBOX_TOKENの代わりに、DROPBOX_REFRESH_TOKEN,DROPBOX_APP_KEY,DROPBOX_APP_SECRETを設定している場合は、これらを用いて一時的なアクセストークンを取得し、これをdropbox-tokenとして用いるようにしました。ドキュメントにも記述を加えました。ご検討いただけると幸いです。