Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use verification-helper: comments instead of .test.cpp extensions to distinguish verification files #391

Open
kmyk opened this issue Jul 16, 2021 · 0 comments

Comments

@kmyk
Copy link
Member

kmyk commented Jul 16, 2021

Description / 説明

The current implementation uses file extensions like .test.cpp to distinguish whether the files are library files or verification files.

We want to use the special comment verification-helper: URL instead to mark the file as a verification file.

Motivation / 動機

The approach with comments allows users to use arbitrary file names. This is important for some languages like Java.

Other notes / その他

  • 拡張子に意味を持たせちゃったのは、実装初期に私がした判断ミスのひとつだと認識している
  • 実装はやるだけだけど、互換性は壊しちゃだめだし変更もきちんと周知しないとだめなので丁寧さが要求される
  • Will you try to create a pull request?
    • no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant