Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The web installer doesn't work when users' default branch are changed. #353

Closed
kmyk opened this issue Dec 14, 2020 · 0 comments · Fixed by #354
Closed

The web installer doesn't work when users' default branch are changed. #353

kmyk opened this issue Dec 14, 2020 · 0 comments · Fixed by #354
Labels

Comments

@kmyk
Copy link
Member

kmyk commented Dec 14, 2020

Description

GitHub introduce the BREAKING CHANGE that changes the name of recommended default branch from master to main. This affects our web installer https://online-judge-tools.github.io/verification-helper/installer.html / GitHub が実質的なデフォルトブランチを master から main に変更してしまった (†破壊的変更†)。これが web installer https://online-judge-tools.github.io/verification-helper/installer.ja.html に影響してる。

具体的には A link to add the example file to your repository みたいなリンクが壊れる。これは https://github.com/beet-aizu/library/new/master?filename=example.test.cpp&value=... みたいな URL に繋がっているが、master branch がないと動かない。

Plans

選択肢は次のどちらかだろう。ユーザの負荷を増やしたくないので (1.) が理想だけど、無理そうなら (2.) になる。

  1. GitHub の API をうまく叩いて default branch を取得し、それを使う
  2. To set up automated verification の steps に「default branch の名前を選んでね: (1.) master, (2.) main, (3.) 自由入力」みたいな step を追加する

Other notes

  • This doesn't affects users who have already installed oj-verify. / すでに oj-verify をインストールしたユーザへの影響はない。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant