Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow for C#/Haskell users fails due to disabled command "add-path" #349

Closed
rajyan opened this issue Nov 24, 2020 · 3 comments · Fixed by #350
Closed

workflow for C#/Haskell users fails due to disabled command "add-path" #349

rajyan opened this issue Nov 24, 2020 · 3 comments · Fixed by #350
Labels
bug Something isn't working difficulty:low priority:high

Comments

@rajyan
Copy link
Contributor

rajyan commented Nov 24, 2020 •
edited

Description

C#ユーザーの設定
https://github.com/online-judge-tools/verification-helper/blob/master/.github/workflows/verify.yml#L34
について

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
にある通り、
add-pathが見つかった脆弱性によってdeprecatedになって使えなくなっていて、C#ユーザーはこれが原因で落ちます。

https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#adding-a-system-path
にあるように修正しようと考えています。

Error log

https://github.com/rajyan/library/actions/runs/378426764

Other notes

  • Will you try to create a pull request?
    • yes
@rajyan rajyan mentioned this issue Nov 24, 2020
Merged
@kmyk kmyk added bug Something isn't working difficulty:low priority:high labels Nov 25, 2020
@kmyk
Copy link
Member

kmyk commented Nov 25, 2020

報告ありがとうございます。落ちてまったく使えなくなるのはこまりますね。

@kmyk
Copy link
Member

kmyk commented Nov 25, 2020

@key-moon 特に何かをしてほしいわけではないですが、とりあえず ping しておきます

@kmyk kmyk linked a pull request Nov 25, 2020 that will close this issue
deleted add-path #350
Merged
@kmyk kmyk closed this as completed in #350 Nov 25, 2020
@kmyk kmyk pinned this issue Nov 25, 2020
kmyk added a commit that referenced this issue Nov 25, 2020
@kmyk
Fix .github/workflows/verify.yml for Haskell and add-path
2894b24 
related #349
@kmyk kmyk mentioned this issue Nov 25, 2020
Merged
@kmyk kmyk changed the title workflow for C# users fails due to disabled command "add-path" workflow for C#/Haskell users fails due to disabled command "add-path" Nov 25, 2020
@kmyk
Copy link
Member

kmyk commented Nov 25, 2020

Haskell も壊れてたので

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working difficulty:low priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deleted add-path rajyan/verification-helper
2 participants
@kmyk @rajyan