Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Cops will be extracted since v0.68.0 #61

Closed
sue445 opened this issue Apr 8, 2019 · 1 comment · Fixed by #69
Closed

Performance Cops will be extracted since v0.68.0 #61

sue445 opened this issue Apr 8, 2019 · 1 comment · Fixed by #69

Comments

@sue445
Copy link
Contributor

sue445 commented Apr 8, 2019

Context

Performance Cops will be extracted since v0.68.0

But onkcop includes Performance cop setting and onkcop will implicitly depend on rubocop-performance
https://github.com/onk/onkcop/blob/v0.53.0.3/config/rubocop.yml#L166-L171

Which of the following do you like?

Plan A

Add rubocop-performance to onkcop as runtime dependency

Plan B

Remove Performance/Casecmp from config/rubocop.yml

Plan C

Other
@onk
Copy link
Owner

onk commented Apr 8, 2019

I plan to extract performance cop settings into a separate file, just as config/rails.yml.

onk added a commit that referenced this issue Jan 2, 2021
@onk
Extract config for rubocop-performance
3ac0a25 
Closes #61
@onk onk mentioned this issue Jan 2, 2021
Merged
@onk onk closed this as completed in #69 Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract config for rubocop-performance onk/onkcop
2 participants
@onk @sue445