Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 9+ modules #21

Closed
jorsol opened this issue Mar 24, 2024 · 3 comments
Closed

Add Java 9+ modules #21

jorsol opened this issue Mar 24, 2024 · 3 comments
Assignees
Milestone

Comments

@jorsol
Copy link
Collaborator

jorsol commented Mar 24, 2024

There are two distinct modules in this project, the scram-common which contains the SCRAM messages and utilities/functions, and the scram-client module.

Add Java modules using MR-JARs:

  • com.ongres.scram.common
  • com.ongres.scram.client
@jorsol jorsol added this to the SCRAM 3.0 milestone Mar 24, 2024
@jorsol jorsol self-assigned this Mar 24, 2024
@bowbahdoe
Copy link

@jorsol This is one of the dependencies I need to have a stable module name to resolve pgjdbc/pgjdbc#2657

Let me know if there is any way i can help

@jorsol
Copy link
Collaborator Author

jorsol commented Mar 31, 2024

Hi @bowbahdoe, there will be a release sooner than later that will be fully modular.

Yet, if you look closely at PgJDBC, this dependency is shaded, so it will not "require" the module-info for the shaded distribution.

@bowbahdoe
Copy link

Oh that's...well I guess good news but a pain in the ass that tooling is such that I didn't notice.

@jorsol jorsol closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants