From 64ded2ed7cacf2c42777ad33466b4ef3b9282026 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Garillot?= Date: Wed, 11 Aug 2021 23:30:36 -0400 Subject: [PATCH] [network] re-activate message signing & verification ensure signerIDs are populated in pubSub tests --- network/p2p/libp2pNode.go | 8 ++++---- network/test/testUtil.go | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/network/p2p/libp2pNode.go b/network/p2p/libp2pNode.go index f1a1b3b51ef..e0aaaf88aaf 100644 --- a/network/p2p/libp2pNode.go +++ b/network/p2p/libp2pNode.go @@ -56,10 +56,10 @@ func DefaultLibP2PNodeFactory(ctx context.Context, log zerolog.Logger, me flow.I // create PubSub options for libp2p to use psOptions := []pubsub.Option{ - // skip message signing - pubsub.WithMessageSigning(false), - // skip message signature - pubsub.WithStrictSignatureVerification(false), + // Use message signing + pubsub.WithMessageSigning(true), + // Use message signature + pubsub.WithStrictSignatureVerification(true), // set max message size limit for 1-k PubSub messaging pubsub.WithMaxMessageSize(maxPubSubMsgSize), // no discovery diff --git a/network/test/testUtil.go b/network/test/testUtil.go index 0d96ab755a9..d1116df46e4 100644 --- a/network/test/testUtil.go +++ b/network/test/testUtil.go @@ -247,10 +247,10 @@ func generateLibP2PNode(t *testing.T, // create PubSub options for libp2p to use psOptions := []pubsub.Option{ - // skip message signing - pubsub.WithMessageSigning(false), - // skip message signature - pubsub.WithStrictSignatureVerification(false), + // with message signing + pubsub.WithMessageSigning(true), + // with no message signature verification + pubsub.WithStrictSignatureVerification(true), // set max message size limit for 1-k PubSub messaging pubsub.WithMaxMessageSize(p2p.DefaultMaxPubSubMsgSize), }