Get nameid when element decrypted twice #205
Merged
+84
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toopy
force-pushed
the
get-nameid-when-element-decrypted-twice
branch
from
e2a8455 to
945fc36
Compare
toopy
force-pushed
the
get-nameid-when-element-decrypted-twice
branch
from
945fc36 to
fac4767
Compare
|
It looks good, let me some days to execute some more tests, merge other PRs and make a new release. |
|
UP |
|
Sorry for the delay, I will test and merge yours PRs today. |
|
No emergency, just a small reminder here ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding tests in our project we figured out that
nameidscould not be decrypted due to a small error. When getting thenameidandnameid_datawe calldecrypt_elementtwice with anetree._Element. The first time the node is decrypted in place, then the decryption method fail on the second call.Additionally it looks like testing keys are equivalent and tests on the method should not fail because of the keys.
In this PR we add an option to decrypt an element in place or copy it before decryption.