Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE-10899] Fix old Observable imports #181

Merged
merged 3 commits into from Apr 15, 2020
Merged

[FE-10899] Fix old Observable imports #181

merged 3 commits into from Apr 15, 2020

Conversation

jonvuri
Copy link
Contributor

@jonvuri jonvuri commented Apr 10, 2020 •
edited

Fix Observable-style imports that were broken by updating to 'umd' module bundling in #148.

Example: https://observablehq.com/@clhenrick/using-mapd-connector-with-mapd3

MapdCon = require("https://rawgit.com/mapd/mapd-connector/master/dist/browser-connector.js")
	.catch(() => new window.MapdCon())

throws:

MapdCon = TypeError: window.MapdCon is not a constructor

The noop externals added to keep Node stuff out of the browser build in #176 had to be removed as a result, too.

@jonvuri jonvuri merged commit 9557f33 into master Apr 15, 2020
@jonvuri jonvuri deleted the jrajav/observable-imports branch April 15, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RavenHursT RavenHursT RavenHursT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonvuri @RavenHursT