Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-10764] Make test host and credentials configurable #178

Merged
merged 2 commits into from Apr 7, 2020

Conversation

israelvicars
Copy link
Contributor

@israelvicars israelvicars commented Apr 6, 2020

Tests can be ran against hosts other than https://metis.mapd.com:443 with custom credentials.

PROTOCOL, HOSTNAME, PORT, USERNAME, PASSWORD, and DATABASE are optional variables that can be used when running the integration tests or example files to use other hosts and crederntials. The default values correspond with the original metis host values and credentials.

Tests have been updated to check for dashboard and table existence instead of the precise values.

The above changes were verified running the updated tests against Metis and Forge.

Merge Checklist

馃敡 Issue(s) fixed:

  • Author referenced issue(s) fixed by this PR: FE-10764

馃毈 Smoke Test

  • Works in chrome
  • Works in firefox
  • Works in safari
  • Works in ie edge
  • Works in ie 11

馃殺 Merge

  • author crafted PR's title into release-worthy commit message.

Copy link
Contributor

@jonvuri jonvuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed by running against a different server that happened to have the same credentials and the necessary tables. Should we make the database name and credentials configurable too so that's not necessary? These are no longer the default credentials for new installs, after all.

@israelvicars israelvicars changed the title [FE-10764] Make host configurable over [FE-10764] Make host configurable Apr 7, 2020
@israelvicars israelvicars changed the title [FE-10764] Make host configurable [FE-10764] Make test host and credentials configurable Apr 7, 2020
@israelvicars
Copy link
Contributor Author

Testing note: node tests had mixed results on some runs, diagnosed as server response latency and unrelated to this issue. Please reach out if testing results are inconsistent.

@israelvicars israelvicars merged commit 1d0b4da into master Apr 7, 2020
@israelvicars israelvicars deleted the israel/FE-10764 branch April 7, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants