Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to use autolinks #3

Merged
merged 2 commits into from Mar 7, 2022
Merged

Fix the ability to use autolinks #3

merged 2 commits into from Mar 7, 2022

Conversation

thatch
Copy link
Contributor

@thatch thatch commented Mar 6, 2022

Description

Fix the ability to use autolinks (links with <> around them). Test included. I poked around at trying to make flake8 or mypy complain about the subclass using different args and in a few minutes of trying, could not. Did notice one import-related problem and fixed that as well.

Fixes: #2

I can't find docs for what this api is supposed to look like, and the
mistune commits are _very_ hard to follow.  This is enough to make
trivial examples start working though, and looking at what mistune
currently provides -- only positional args -- this should be ok:

```
$ grep "'link" mistune/inline_parser.py
        return 'link', escape_url(link), text
        return 'link', escape_url(link), text, title
```
@amyreese amyreese merged commit 31530d0 into omnilib:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolinks do not work
2 participants