Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolinks do not work #2

Closed
thatch opened this issue Mar 6, 2022 · 0 comments · Fixed by #3
Closed

Autolinks do not work #2

thatch opened this issue Mar 6, 2022 · 0 comments · Fixed by #3

Comments

@thatch
Copy link
Contributor

thatch commented Mar 6, 2022

Description

The "autolink" method is no longer used, and it appears that they go through the regular "link" codepath just with no title. Mistune also uses "children" instead of "text" but because it's positional, this doesn't matter?

Noticed on https://github.com/facebookexperimental/usort/runs/5416284967?check_suite_focus=true

Exception occurred:
  File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\site-packages\mistune\inline_parser.py", line [20](https://github.com/facebookexperimental/usort/runs/5416284967?check_suite_focus=true#step:7:20)7, in <genexpr>
    for t in self._scan(s, state, rules)
TypeError: link() missing 1 required positional argument: 'title'

PR incoming...

Details

  • OS: Win/Mac/Lin
  • Python version: 3.6-3.10
  • Project version: 0.5.0 (and main)
  • Can you repro on main? yes
  • Can you repro in a clean virtualenv? yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant