Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mistune dependency #15

Merged
merged 1 commit into from Oct 10, 2022
Merged

Conversation

Mulugruntz
Copy link
Contributor

Description

This is a follow-up to #13.
Full description of the issue: https://github.com/amyreese/sphinx-mdinclude/issues/12
The fix presented here is to restrict mistune dependency to only 2.* and not just >=2.

Fixes: #12

Changes made

  • mistune dependency is now 2.*;

Signed-off-by: Samuel Giffard <samuel.giffard@teampicnic.com>
@Mulugruntz
Copy link
Contributor Author

Let's break this out into separate PR's for each piece:

  • re mistune, is there an easy way to support both major versions at once, rather than pinning to an old version? I'd rather have some if/else or try/except imports than limit to an older version unnecessarily.
  • re changelog: this is generated by another project, attribution based on git tags, so any changes here will get clobbered at the next release. I'm happy to accept a PR to attribution that improves the output format.
  • re version: this is also managed by attribution, so please do not change the version file directly. Perhaps attribution could add a simple comment explaining that.

Originally posted by @amyreese in https://github.com/amyreese/sphinx-mdinclude/issues/13#issuecomment-1241432354

Thanks a lot for you super quick reply :-).

What I would suggest is to have the mistune fix in 2 steps:

  1. pinning (immediate fix). <-- this is what this PR does.
  2. extending the support and enlarging the deps.
    • I can open a new issue to keep track of that future follow-up.

About the changelog, I'll see if I can quickly submit a fix to attribution :-).

@amyreese amyreese mentioned this pull request Oct 10, 2022
@amyreese amyreese merged commit 3636e33 into omnilib:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'PLUGINS' from 'mistune.plugins'
2 participants