Better type hint for Connection.text_factory #179
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text_factory type hint was simply "Type" which is kinda right for the most common cases of the parameter (str and bytes). However, text_fatory can be any other callable that accepts a bytes parameter and returns the resulting object as described in the docs for sqlite3 python standard module. (ref: https://docs.python.org/3/library/sqlite3.html ) In particular this fix is for support another common enough idiom, which is setting `conn.text_factory = lambda b: b.decode(errors=ignore)`
|
Hi, have you been able to review this? |
|
Sorry I missed that! Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text_factory type hint was simply "Type" which is kinda right for the
most common cases of the parameter (str and bytes).
However, text_fatory can be any other callable that accepts a bytes
parameter and returns the resulting object as described in the docs for
sqlite3 python standard module.
(ref: https://docs.python.org/3/library/sqlite3.html )
In particular this fix is for support another common enough idiom,
which is setting
conn.text_factory = lambda b: b.decode(errors=ignore)