Do not restrict maximum version of Hashie. #979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing #977 which fixed the build here, and seeing that the current hashie master build is broken on an integration spec with Omniauth.
The only reason to introduce a version restriction for hashie is if you know that a gem is incompatible with a certain version of hashie. Currently we know that omniauth requires hashie >= 3.4.6. There's no need to restrict against a future hashie 5, similarly as there was no need to restrict against hashie 4, which released a while ago and works great with omniauth.