Ensure mock call verifies authenticity tokens with same logic as real call #1033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readjusts when the authenticity token verification happens in
#mock_call
to align with the execution of the real call.Purpose
The current implementation of
mock_call
was verifying the token for all requests, regardless of whether the current path is on the omniauth request path. The change was introduced recently in 1b784ff. See #1032 for details.This creates two problems:
Approach
#mock_request_call
so that it tracks more closely with the real validation logic that is triggered from#request_call
.Please feel free to introduce this change in a different manner if needed. My main interest is unblocking a project I have where the newly introduced logic change is breaking many tests. We are disabling the
request_validation_phase
in all tests, but would like to re-enable it for integration tests to ensure our tests specify the behavior correctly.