Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@agrobbin @sferik Could you review this, if you still have an interest in the issue? #154

Open
Noip1 opened this issue Jun 21, 2022 · 1 comment

Comments

@Noip1
Copy link

Noip1 commented Jun 21, 2022

@agrobbin @sferik Could you review this, if you still have an interest in the issue?

#70 was merged without a spec, so I added specs to make my intention clear. If redirect_uri is given in token_params, it should be honored. If not, query parameters added by the OAuth2 provider in a callback should be stripped off from the redirect_uri value to be posted to the token endpoint, to avoid redirect_uri mismatch.

Originally posted by @knu in #100 (comment)

@Noip1 Noip1 closed this as completed Jun 21, 2022
@Noip1 Noip1 reopened this Jun 21, 2022
@agrobbin
Copy link
Contributor

@Noip1 I am not a maintainer of this gem, and contributed #70 more than 7 years ago, so I don't know what my review will add, but I have left a comment on #100 regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants