Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKCE Support #130

Closed
jessedoyle opened this issue Jun 10, 2020 · 1 comment · Fixed by #131
Closed

PKCE Support #130

jessedoyle opened this issue Jun 10, 2020 · 1 comment · Fixed by #131

Comments

@jessedoyle
Copy link
Contributor

The IETF now recommends the use of PKCE (Proof Key for Code Exchange) to protect OAuth2 code authorization grants.

Would you consider adding support for optional PKCE in omniauth-oauth2? I've implemented it manually a number of times now and would be happy to submit a PR.

Relevant RFC: https://tools.ietf.org/html/rfc7636

Thanks!
@jessedoyle jessedoyle mentioned this issue Jun 23, 2020
Merged
@jessedoyle
Copy link
Contributor Author

PR submitted: #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OAuth2 - PKCE jessedoyle/omniauth-oauth2
1 participant
@jessedoyle