Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide refresh token, whether access token expires or not #122

Open
RKushnir opened this issue Sep 12, 2018 · 0 comments
Open

Always provide refresh token, whether access token expires or not #122

RKushnir opened this issue Sep 12, 2018 · 0 comments

Comments

@RKushnir
Copy link

RKushnir commented Sep 12, 2018

I found this line that only exposes the refresh token if the access token has an expiration time

hash["refresh_token"] = access_token.refresh_token if access_token.expires? && access_token.refresh_token

My problem is, Twitch OAuth has expiring access tokens, but they don't tell you when the token is going to expire(access_token.expires? returns false). So you would want to keep the refresh token and use it whenever that expiration happens.

I wonder why this condition was added, is it to conform to some spec? And can we remove it to always provide the refresh token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant