Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access_token query parameter is going to be deprecated #89

Closed
gionn opened this issue Feb 17, 2020 · 3 comments
Closed

Access_token query parameter is going to be deprecated #89

gionn opened this issue Feb 17, 2020 · 3 comments

Comments

@gionn
Copy link

gionn commented Feb 17, 2020 

Please use the Authorization HTTP header instead as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

ref: https://community.zammad.org/t/github-login-deprecation-notice-with-zammad-2-10-0/3986
@BobbyMcWho
Copy link
Member

Hello @gionn,

Can you please add what version of omniauth-github you are seeing this in? I believe this should have been fixed as of the last minor version release 1.4.0

#84

@gionn
Copy link
Author

gionn commented Feb 17, 2020

https://github.com/zammad/zammad/blob/develop/Gemfile.lock#L324

I'll ask to upstream project maintainers to upgrade to 1.4.0 to see if it solve.

Thanks for your prompt reply!

@gionn gionn mentioned this issue Feb 17, 2020
Closed
@BobbyMcWho
Copy link
Member

@gionn feel free to reopen if that for some reason didn't work for you

@JunichiIto JunichiIto mentioned this issue Apr 12, 2020
Merged
@takeyuweb takeyuweb mentioned this issue Aug 3, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gionn @BobbyMcWho