Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit code generated by prost-build #41

Closed
MCOfficer opened this issue Apr 3, 2024 · 2 comments · Fixed by #42
Closed

Commit code generated by prost-build #41

MCOfficer opened this issue Apr 3, 2024 · 2 comments · Fixed by #42

Comments

@MCOfficer
Copy link
Contributor

MCOfficer commented Apr 3, 2024

Since v0.11 (4fea65b), prost-build requires protoc to be installed while compiling. This means any downstream application / library of bitar also needs it to compile.

Seeing how "the new recommendation for libraries is to commit their generated protobuf" (tokio-rs/prost#657), it's probably best for bitar to ship the generated code, rather than generating it at compile-time.

@oll3
Copy link
Owner

oll3 commented Apr 3, 2024

Since v0.11 (4fea65b), prost-build requires protoc to be installed while compiling. This means any downstream application / library of bitar also needs it to compile.

Seeing how "the new recommendation for libraries is to commit their generated protobuf" (tokio-rs/prost#657), it's probably best for bitar to ship the generated code, rather than generating it at compile-time.

Sure, seems reasonable to include the source. I guess we would regenerate it manually if wanted and then remove bitar/build.rs. Would you like to create a PR?

@MCOfficer
Copy link
Contributor Author

I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants