Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeqNoAndPrimaryTerm vs. SeqNoPrimaryTerm #1593

Closed
mitar opened this issue Mar 1, 2022 · 1 comment
Closed

SeqNoAndPrimaryTerm vs. SeqNoPrimaryTerm #1593

mitar opened this issue Mar 1, 2022 · 1 comment
Milestone

Comments

@mitar
Copy link

mitar commented Mar 1, 2022

Which version of Elastic are you using?

[x] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)

Please describe the expected behavior

There seems to be inconsistency how SeqNoAndPrimaryTerm is named between services. Sometimes is SeqNoAndPrimaryTerm (SearchSource) and sometimes is SeqNoPrimaryTerm (SearchService). I would expect them to be the same.

@olivere
Copy link
Owner

olivere commented Mar 19, 2022

I would expect so as well. However, we're just mirroring what the server does. See here. The correct naming would be seqNoAndPrimaryTerm though.

@olivere olivere added this to the 7.0.32 milestone Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants